rust-av / av-metrics

Quality metrics
MIT License
54 stars 10 forks source link

Add av-metrics-gui-tool #290

Closed Luni-4 closed 3 years ago

Luni-4 commented 3 years ago

This PR adds av-metrics-gui-tool, an iced GUI tool that computes video metrics.

Since the building is extremely slow due to the great amount of dependencies, for now the tool is not a workspace member, but I'm planning to add a deploy action in a following PR.

The tool also runs on web too thanks to the WebAssembly support provided by iced, but it needs more in depth tests.

Thanks in advance for your review!

vibhoothi commented 3 years ago

Can you please add some screenshots for quick view^^

Luni-4 commented 3 years ago

@vibhoothi

Yep, I need to fix some stuff and clean up the code a bit, I'm going to work on it as soon as I can

Luni-4 commented 3 years ago

@vibhoothi @shssoichiro

We can consider this PR ready. The GUI can compute video metrics on Linux and Windows through FFmpeg, and Y4m also, furthermore we have also added a script to automatically deploy the FFmpeg binaries.

What we were not able to achieve:

Here the artifacts produced by the script: https://github.com/Luni-4/av-metrics/actions/runs/1208712639 To run the wasm32 binary and JavaScript bindings, one can use the python3 -m http.server in the artifact's folder and see the result through a browser.

Luni-4 commented 3 years ago

@vibhoothi

I tidied up the code a bit, I think we can merge it. You can find the final release here. I will iterate over the MacOS target later.

Wasm-32 can't be run in an easy way because we have a problem with the parallelism provided by rayon, there is a workaround but it doesn't work on any browser as stated here