search

rust-av / av-metrics

Quality metrics
MIT License
54 stars 10 forks source link

Fix FFmpeg build #300

Closed FreezyLemon closed 7 months ago

FreezyLemon commented 7 months ago

Fixes the error that showed up in #299.

non-exhaustive-enums is a feature that basically allows compiling the ffmpeg crate even when the installed FFmpeg libraries are newer than the crate supports.

This comes at the cost of implicitly ignoring new enum variants in the FFmpeg API, which is probably fine.

The alternative solution to this would be updating the ffmpeg crate to support the newest version (and keep it updated). Or change the CI so it only installs a fixed FFmpeg version.

FreezyLemon commented 7 months ago

Note that clippy/rustfmt fails, but the builds (what this PR is supposed to fix) succeed.

Just to prove that both PRs combined will fix CI: FreezyLemon/av-metrics#2

FreezyLemon commented 7 months ago

Not necessary if ffmpeg-the-third is updated