Document the current butteraugli implementations

rust-av / butteraugli-rs

butteraugli quality metric - rust port

Apache License 2.0

3 stars 2 forks source link

Document the current butteraugli implementations #1

Open lu-zero opened 3 years ago

lu-zero commented 3 years ago

butteraugli has two implementations one stand alone and one integrated in the implementation of jpegxl.

[ ] Write a blogpost comparing the two implementations
- [ ] Confirm that they produce different (or identical) results for a testsuite
- [ ] Make a list of the functions, what they do and how they interact.
[ ] Benchmark the two implementation
- [ ] Use perf to profile them and compare the results.

sn99 commented 3 years ago

Blogpost link; there will be a PART 2 most likely, but at end of 1 month, need to go deeper, all topics have been covered for now but will be expanded further.

lu-zero commented 3 years ago

Make sure you add a summary:

do the two implementation provide the same output for the same input?
how is the code different? (e.g. how hard would be to avoid https://github.com/google/highway ?)
the list of function seems missing

I appreciate that you described how the code evolved with an example and that you get some insights from the original author.

I'm looking forward to read the second part

sn99 commented 3 years ago

Alright !

do the two implementation provide the same output for the same input?

Nope, jpeg xl changed a few things.

how is the code different? (e.g. how hard would be to avoid https://github.com/google/highway ?)

Highway can be completed avoided as it has not yet been SIMDfied or so the developer said. And Rust does it by default?. Although we can use https://github.com/rust-lang/stdsimd for more?

the list of function seems missing

Will do that hopefully after I have made a few more functions in pure Rust