search

rust-av / dav1d-rs

libdav1d rust bindings
MIT License
40 stars 20 forks source link

API change for Picture::plane_data() #21

Closed philn closed 4 years ago

philn commented 5 years ago

This method now returns a slice and the stride associated with the requested plane component. This is more convenient when safely copying the decoded picture.

The plane data pointer is now accessible through the plane_data_ptr() method.

philn commented 4 years ago

@lu-zero can you review this PR please? I'm using this API in the GStreamer plugin :)

sdroege commented 4 years ago

Looks fine to me, if @sdroege is happy as well I guess it can land and we can have another release.

Looks mostly good to me, just some style/minor things.

sdroege commented 4 years ago

Thanks! As @lu-zero was already fine with the changes before and this is mostly cosmetics (and the build.rs change is useful anyway), let's get it in then :)

lu-zero commented 4 years ago

Is there anything more to add or shall we move to release?

philn commented 4 years ago

We're good for a release I think. The next "big" task will be to add custom allocator support but I would defer it to another future release.