rust-av / ssimulacra2_bin

Binary interface for the ssimulacra2 Rust port
BSD 2-Clause "Simplified" License
40 stars 10 forks source link

Score deviates from upstream #15

Open ghtm2 opened 1 year ago

ghtm2 commented 1 year ago

Hi.

I've just compiled both upstream and this and was a bit surprised to find quite a bit of deviation in the score on the same set of images.

Here is a sample.

With upstream ssimulacra2 I get a score of 77.94549165, with ssimulacra2_bin one of 78.74256984.

Is this known/expected?

FreezyLemon commented 1 year ago

This is known and pretty much unavoidable. Both the C++ and the Rust versions have some optimizations in (maybe different) places to increase speed in certain places, and unless there is extra effort invested into matching these optimized functions 1:1, there will always be a difference.

That said, if the deviation is too large it is actually a problem, so it might be worth investigating this more.