search

rust-bakery / nom

Rust parser combinator framework
MIT License
9.4k stars 807 forks source link

Upgrade to a newer version of bitvec #1311

Closed Fiono11 closed 3 years ago

Fiono11 commented 3 years ago

Any prevision of when the crate will be updated to a newer version of bitvec?

ValHeimer commented 3 years ago

I would need this too, because when I try to run "cargo tarpaulin" on my crate (using nom) with Rust 1.52.1, I have the following error:

error: Broken pipe (or error 32)
error: could not compile `bitvec`
ERROR: cargo_tapaulin: Failed to compile tests! Error: cannot find attribute `skip` in this scope

and I hope (let me hope) that it will fix this issue :)

orhun commented 3 years ago

Same issue with the tarpaulin here.

ValHeimer commented 3 years ago

I would need this too, because when I try to run "cargo tarpaulin" on my crate (using nom) with Rust 1.52.1, I have the following error:

error: Broken pipe (or error 32)
error: could not compile `bitvec`
ERROR: cargo_tapaulin: Failed to compile tests! Error: cannot find attribute `skip` in this scope

and I hope (let me hope) that it will fix this issue :)

@orhun seems to be a Tarpaulin issue, in fact... https://github.com/xd009642/tarpaulin/issues/756

Geal commented 3 years ago

erf, that tarpaulin issue is caused by nom https://github.com/xd009642/tarpaulin/issues/756#issuecomment-834249299 and appears in nom's CI too https://github.com/Geal/nom/runs/2865070181?check_suite_focus=true

damccull commented 3 years ago

This doesn't happen for me on wsl2 but it's happening with actions-rs on github actions. Anyone know how to fix?

Edit: Turns out this is caused by some change in the toolchain. I can get this to work find with 1.49.0 but not on 1.5.2 or higher.

edward-shen commented 3 years ago

@Geal, would it be possible for you to backport the bitvec dependency update you did in 03a1025a5d98df931f12b1935d04f7bd9fe7752c to a 6.2.2 release as well? Propagation of the fix should be a lot easier than a major version bump.

Edit: apologies, it looks like 6.2.1 was the backported fix.

Geal commented 3 years ago

bitvec input types are now in the nom-bitvec crate, since the release of nom 7: https://crates.io/crates/nom/7.0.0