search

rust-bakery / nom

Rust parser combinator framework
MIT License
9.38k stars 806 forks source link

move usage towards AsChar method instead of functions under the character module #1597

Closed Geal closed 5 months ago

Geal commented 1 year ago

this reduces duplication a bit

the implementation comes from:

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3807373087

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/traits.rs 0 16 0.0%
<!-- Total: 0 16 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/character/mod.rs 10 0%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 3796683738: -0.8%
Covered Lines: 1489
Relevant Lines: 2448
💛 - Coveralls
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 61.43%. Comparing base (cea6595) to head (6303c74). Report is 1 commits behind head on main.

Files Patch % Lines
src/traits.rs 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1597 +/- ## ========================================== - Coverage 62.14% 61.43% -0.72% ========================================== Files 24 24 Lines 2922 2938 +16 ========================================== - Hits 1816 1805 -11 - Misses 1106 1133 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 5 months ago

CodSpeed Performance Report

Merging #1597 will not alter performance

Comparing epage-aschar (6303c74) with main (cea6595)

Summary

✅ 24 untouched benchmarks