search

rust-bakery / nom

Rust parser combinator framework
MIT License
9.18k stars 792 forks source link

Make Error clonable #1650

Closed xmakro closed 1 year ago

xmakro commented 1 year ago

Err is clonable, but error::Error was not.

I ran into this while updating the warc crate from nom 5.1.1 to nom 7.1.3 on this callsite: https://github.com/jedireza/warc/blob/b2b9dfca0d81ed5a91e0016ea89022caf5283ec4/src/record.rs#L182

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4430845702

Totals Coverage Status
Change from base Build 4430830784: 0.0%
Covered Lines: 1557
Relevant Lines: 2495
💛 - Coveralls
Geal commented 1 year ago

thanks!

xmakro commented 1 year ago

Thanks for merging! Could you please release a new version? Then I can fix the dependant crate. Thanks!