Closed martinfrances107 closed 6 months ago
Comparing martinfrances107:bump_MSRV
(367c529) with main
(2560d5c)
⚡ 1
improvements
❌ 1
regressions
✅ 22
untouched benchmarks
:warning: _Please fix the performance issues or acknowledge them on CodSpeed._
Benchmark | main |
martinfrances107:bump_MSRV |
Change | |
---|---|---|---|---|
❌ | recognize float str |
1 µs | 1.2 µs | -14.2% |
⚡ | number |
287.2 ns | 259.4 ns | +10.71% |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.42%. Comparing base (
2560d5c
) to head (367c529
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
looking at the 14% drop in preformance ( A change to 1 µs to 1.2 µs ) well that looks completely to be expect from from repeatibility noise.
The +10% imrpovement ( from 287.2 ns to 259.4 ns ) is a welcome minor improvement
In short, I think being blocked on this is misguided.
chill a bit. Benchmarks can be flaky, that's not an issue, and this change definitely cannot affect performance
As the code has been updated new features that break the currently stated MSRV have been added.
I just want the codebase to reflect reality.
This issue can be seen by running cargo clippy