search

rust-bakery / nom

Rust parser combinator framework
MIT License
9.47k stars 806 forks source link

Add missing tests for number parsing #1769

Open CXWorks opened 3 months ago

CXWorks commented 3 months ago

Hi,

Thanks for your time & patience to review this PR.

We are researchers focusing on Rust unit tests, we revised our tool for better readability. By examine the existing code, we found several unit tests can be added to improve the repo's overall unit test coverage(this project is already been well tested).

Thanks again for your time.

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #1769 will degrade performances by 19.3%

Comparing CXWorks:main (d0e2173) with main (561fb6b)

Summary

❌ 1 regressions ✅ 23 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main CXWorks:main Change
❌ number 121.9 ns 151.1 ns -19.3%