search

rust-bio / rust-bio-tools

A set of command line utilities based on Rust-Bio.
MIT License
182 stars 24 forks source link

fix: vcf-report tests #215

Closed FelixMoelder closed 2 years ago

FelixMoelder commented 2 years ago

This adds tests which have not been pushed in the previous PR.

FelixMoelder commented 2 years ago

@fxwiegand Could you have a look at the failing test? It appears to me as if tests/expected/report/details/a/ENST00000557334_5_c_35G_A.html is not up to date and I would expect a link to the Changelog.md. But as the line did not change in the last weeks I do not get how the test could have passed before.

fxwiegand commented 2 years ago

@fxwiegand Could you have a look at the failing test? It appears to me as if tests/expected/report/details/a/ENST00000557334_5_c_35G_A.html is not up to date and I would expect a link to the Changelog.md. But as the line did not change in the last weeks I do not get how the test could have passed before.

I'd assume the problem is that the additional import moved all lines down so the test doesn't delete the timestamp and version anymore. You'd need to change this line: https://github.com/rust-bio/rust-bio-tools/blob/ebb2f0996fc90340a872ccb473b3ca171e5a9bd6/tests/lib.rs#L211

FelixMoelder commented 2 years ago

@fxwiegand Could you have a look at the failing test? It appears to me as if tests/expected/report/details/a/ENST00000557334_5_c_35G_A.html is not up to date and I would expect a link to the Changelog.md. But as the line did not change in the last weeks I do not get how the test could have passed before.

I'd assume the problem is that the additional import moved all lines down so the test doesn't delete the timestamp and version anymore. You'd need to change this line:

https://github.com/rust-bio/rust-bio-tools/blob/ebb2f0996fc90340a872ccb473b3ca171e5a9bd6/tests/lib.rs#L211

Thanks! Guess I would have spent hours to figure that out on my own.