search

rust-bio / rust-bio-tools

A set of command line utilities based on Rust-Bio.
MIT License
182 stars 24 forks source link

build: Update rust-htslib to 0.46.0 and GSL to 7.0.0 for Linux ARM64 compatibility #259

Closed martin-g closed 6 months ago

martin-g commented 6 months ago

Related to: https://github.com/rust-bio/rust-bio-tools/commit/0ffaf4d29776b373c0a0187ec4496d2f51e2f8cf#commitcomment-140597552

fxwiegand commented 6 months ago

test_vcf_annotate_dgidb seems to fail in testing.

https://github.com/rust-bio/rust-bio-tools/blob/37e3dbe744c544d645fed8302f27e443eba28491/tests/lib.rs#L356-L363

martin-g commented 6 months ago

I'll take a look soon !

martin-g commented 6 months ago

I think I fixed the problem! http://dgidb.org/api/v2/interactions.json returns 404. Now only HTTPS is supported. But this means that also the old versions of rbt should be broken.

fxwiegand commented 6 months ago

I think I fixed the problem! http://dgidb.org/api/v2/interactions.json returns 404. Now only HTTPS is supported. But this means that also the old versions of rbt should be broken.

Thanks for digging into this! Yes indeed it seems weird that the test didn't fail in earlier releases.

martin-g commented 6 months ago

Very welcome! I'd like to ask again for a new release please ! :-)

fxwiegand commented 6 months ago

Very welcome! I'd like to ask again for a new release please ! :-)

Yep I'll try to make it happen asap. I don't have admin rights so I cannot git commit --allow-empty -m "chore: release 0.42.2" -m "Release-As: 0.42.2" on the main branch to force release-please to Create a new PR.

martin-g commented 6 months ago

Friendly ping!

fxwiegand commented 6 months ago

Friendly ping!

On it thx!

Edit: And the release is out!

martin-g commented 6 months ago

Thank you, @fxwiegand !