Closed afilini closed 4 years ago
@afilini Can you please test that this is fixed by https://github.com/rust-bitcoin/bitcoin_hashes/pull/100 ?
Yes, adding that branch as a patch to our Cargo.toml
fixes the issue.
Sorry for the trouble, I forgot to check in the pull requests section and only checked if there was already another issue open for the same problem.
Sorry for letting this sit all weekend. Published 0.9.2 and yanked 0.9.1. Should be good now.
I'm still investigating this, so I'm not entirely sure whether this is our fault in
bdk
or if this is due tobitcoin_hashes
.Anyways, it looks like the newly-released
0.9.1
makesbdk
builds fail with an error regarding the use of private modules somewhere inbitcoin_hashes
(see attached log).This was not happening with
0.9.0
and build trees that still have a cached0.9.0
copy ofbitcoin_hashes
will still happily compile. Runningcargo update
and forcing the update ofbitcoin_hashes
in those trees to the new release will then make the build fail.It should be noted that we don't directly import
bitcoin_hashes
as a dependency, but we depend on it indirectly throughbitcoin 0.25
.Issue in our repo: bitcoindevkit/bdk#136