Closed tcharding closed 2 years ago
This is a breaking change and requires a major version bump.
Whats the policy for changes like this across the rust-bitcoin stack? Should this PR have included a change to bump the version number or do we rely on you to work this out when you do the release?
@tcharding we don't have an explicit policy ... but yes, "we rely on me to work it out" is usually what we do.
Sometimes people want a minor version bump for some specific feature, in which case I ask them to put the bump into the PR ... but for major ones I don't think we ever do that.
Friendly bump please review crew.
Let's do it. We can bring this into the MSRV-bumping release, this crate is simple enough that I don't worry about breaking too much at once.
Currently we use
Default::default()
to get an all zeros hash. This is confusing because an all zeroes hash does not have a real meaning since there is no known input to create it. The all zeros hash is, however used by the Bitcoin network to signify certain things (e.g. the previous blockhash in the genesis block).Remove the
Default
implementation from theHash
trait and add aall_zeros
method instead. Remove theDefault
derive from any hash type that has it.To see the patch to
rust-bitcoin
that this PR imposes, check out this branch.Resolves #139