Closed RCasatta closed 2 years ago
concept ACK, though CI is failing
CI fail is because you include test
in the cfg feature gating but io
is not imported for test
. Since I did the change to see if tests pass here it is:
#[cfg(any(test, feature = "std"))]
use std::io;
@tcharding are your nits addressed?
Yep, thanks for checking with me!
This struct create an hex string from a writer, in cases where you have an encodable object this allows skipping the creation of the intermediate
Vec<u8>
Useful in rust_bitcoin
serialize_hex
https://github.com/rust-bitcoin/rust-bitcoin/blob/0e82376bf85137494ff220608e80b9c78c1932b5/src/consensus/encode.rs#L149 but needs https://github.com/rust-bitcoin/rust-bitcoin/pull/1027 so that result string size is known ahead of time