Closed tcharding closed 2 years ago
concept ACK doing this (and ack the claim that the _
was a mistake on my part).
Not sure whether this is worth the trouble .. will let others weigh in.
I just added a symlink bitcoin-hashes
-> bitcoin_hashes
and that takes care of basically all the interaction I have on a regular basis with this underscore. Closing.
The underscore in
bitcoin_hashes
is an accident of history (sorry I can't find the quote, perhaps you can ack this statement please @apoelstra).Everywhere else in the
rust-bitcoin
stack we use-
. This makes it mildly annoying to interact withbitcoin_hashes
. We cannot rename the crate on crates.io because_
and-
are treated the same. We can rename the directory and repository on github.com and everything should still work.What we could do is rename the github repository, change all the URLs in the manifest but keep the package name as
bitcoin_hashes
. We can also do package re-names in dependencies now with our new MSRV so in, for example,rust-bitcoin
we could haveA little comment in the file
bitcoin-hashes/Cargo.toml
would let folks know what we are doing:Not sure if this is worth the trouble but it reduces the scope of the an accident that cannot be totally fixed.