search

rust-bitcoin / bitcoin_hashes

Simple library which implements a few hashes and does nothing else
Creative Commons Zero v1.0 Universal
66 stars 52 forks source link

Hack around the broken dyn-clone dependency #167

Closed tcharding closed 2 years ago

tcharding commented 2 years ago

The current version of dyn-clone v1.0.8 breaks our build (uses Arc::as_ptr which only became available in Rust 1.45).

We can pin the dependency to a version before that works. Requires some toml magic akin to what we do with actual-serde in rust-bitcoin.

apoelstra commented 2 years ago

Cool, I think this minimally irritates both me and @JeremyRubin. Let's do it.

JeremyRubin commented 2 years ago

Looks fine to me! Thanks

On Thu, Jul 21, 2022, 5:37 AM Andrew Poelstra @.***> wrote:

Cool, I think this minimally irritates both me and @JeremyRubin https://github.com/JeremyRubin. Let's do it.

— Reply to this email directly, view it on GitHub https://github.com/rust-bitcoin/bitcoin_hashes/pull/167#issuecomment-1191432499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGYN675C5VSV6IXHZTWHRLVVFABZANCNFSM54F2W7ZA . You are receiving this because you were mentioned.Message ID: @.***>