search

rust-bitcoin / bitcoind

Utility to launch a regtest bitcoind process in a rust test
MIT License
41 stars 34 forks source link

Add ZMQ interface for BitcoinD #150

Closed bennyhodl closed 10 months ago

bennyhodl commented 10 months ago

Create the ZMQ interfaces and expose them through BitcoinD

Moved this upstream because I created a utility for LND and needed to add a function to retrieve the ZMQ interface.

bennyhodl commented 10 months ago

Bump @RCasatta

RCasatta commented 10 months ago

Thanks for the bump, I missed it.

Absolutely concept ack but I think we should add a config.enable_zmq or similar for enabling zmq which is false by default. My fear is using too many ports...

bennyhodl commented 10 months ago

@RCasatta added an optional config. Can rebase if it looks good

RCasatta commented 10 months ago

LGTM, if you can squash and run cargo fmt

You can ignore CI error on windows, and also ignore clippy warnings.

RCasatta commented 10 months ago

ACK f69adc1ad3a5e77a64d2dd6596c8e2ab5ef08504