search

rust-bitcoin / rust-bech32-bitcoin

Encoding and decoding Segregated Witness addresses in Bech32 format
16 stars 25 forks source link

Upgrade Bech32 Dependency to 0.7.1 #25

Closed clarkmoody closed 4 years ago

clarkmoody commented 4 years ago

Updates to the latest bech32 version.

The WitnessProgram struct's bech32 field becomes a simple String, rather than the previous Bech32 struct from older versions of the library.

Brings the TravisCI minimum Rust version up to 1.22 to match other projects within rust-bitcoin.

clarkmoody commented 4 years ago

Do you need this outside of rust-bitcoin? Afaik rust-bitcoin/rust-bitcoin#255 will remove the bech32-bitcoin dependency so that rust-bitcoin relies directly on rust-bech32.

I don't. I just wanted to bring it up to the latest rust-bech32 to check out the ergonomics.

Moving away from this lib is actually a good idea, especially going forward. I was looking into Taproot addresses, and validation requires checking the point against an elliptic curve. It would be better to do that sort of validation within a broader consensus-aware framework, such as rust-bitcoin.