search

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
94 stars 49 forks source link

Add segwit API #120

Closed tcharding closed 1 year ago

tcharding commented 1 year ago

Add a segwit API with the aim that "typical" modern bitcoin usage is easy and correct.

Done in a separate module so as not to impact the main crate API.

tcharding commented 1 year ago

Hey @apoelstra check this out, its so-hot-right-now :)

apoelstra commented 1 year ago

Nice! d45699f951e0b14cfc4d1433782906d677e5f8d3 looks pretty good. I have some nits about the comments, mainly. Think this can be undrafted.

tcharding commented 1 year ago

Cool, I'll go over it again today (after I fix the uppercase QR code thing) and undraft. Want to put this in before the alpha release?

apoelstra commented 1 year ago

Yeah, let's get it in before alpha. We're pretty close.

tcharding commented 1 year ago

Thanks for the review @clarkmoody!