rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
94 stars 49 forks source link

Add transparent representation for u5 #122

Closed citizen-stig closed 1 year ago

citizen-stig commented 1 year ago

As mentioned in https://github.com/rust-bitcoin/rust-bech32/issues/19 having transparent representation for u5 opens many optimization.

According to change log in Rust repo, this feature was stabilized in 1.28

apoelstra commented 1 year ago

LGTM. I don't see your citation for this opening up optimizations, but it seems like an obvious thing to do (and we'll never change this type from being a u8 internally).