Fix checksum error type

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding

MIT License

93 stars 49 forks source link

Fix checksum error type #150

Closed tcharding closed 10 months ago

tcharding commented 10 months ago

We have a couple of checksum error problems;

Unused checksum related variants in CharError
Unuseful error message (duplicated string "invalid checksum")

Fix both at the same time by removing the unused variants from CharError and by renaming the InvalidChecksum variant to InvalidResidue and improving the Display impl appropriately.

tcharding commented 10 months ago

Hope you weren't still reviewing, I force pushed the string change as suggested.