search

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
93 stars 49 forks source link

benchmarks: restore benchmarks #182

Closed apoelstra closed 2 months ago

apoelstra commented 5 months ago

In #128 we dropped the benchmarks. They can be restored with only minor tweaks, so do so.

apoelstra commented 5 months ago

CI failure is just because nightly rustc has introduced a new Freeze trait which appears in the check-API check. There is a commit to fix this in #180 which I won't copy into here to avoid rebase trouble.

apoelstra commented 5 months ago

cc @clarkmoody this is a quick/easy PR. Can you do a quick review?

Alternately, would you be okay with my merging things here with only ACKs from @tcharding?

tcharding commented 2 months ago

Needs api files updating @apoelstra

tcharding commented 2 months ago

Also I've emailed Clark to see what is the status here and on #180.

apoelstra commented 2 months ago

Rebased, added a one-line warning fix from my error-correction-2 branch, and also added a benchmark for parameter generation.