search

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
93 stars 49 forks source link

Add Default trait to Fe32 (derived) #184

Closed optout21 closed 1 month ago

optout21 commented 1 month ago

See #187 .

Add derived Default trait to Fe32, and ZERO constant. Default is trivial to add, but it is useful in some cases.

apoelstra commented 1 month ago

Can you update the API file? You can run just check-api or read the justfile to see the manual invocation.

optout21 commented 1 month ago

API doc updated

tcharding commented 1 month ago

Oh there are two PRs (also #185), can you drop the second patch off this PR please.

tcharding commented 1 month ago

Oh boy, this is all mixed up, I got confused. You have the changes in #184 and #185 in a single patch described in two PRs.

optout21 commented 1 month ago

I created separate PRs for all the different changes (Default trait, ZERO const, Ord trait), to keep changes minimal. But the ZERO const was in fact in this PR as well. I've removed it now.

clarkmoody commented 1 month ago

Ok, I'd like to see the commit history cleaned up for this one. It can probably be done in a single commit, so squashing might work.

optout21 commented 1 month ago

Squashed into one commit

tcharding commented 1 month ago

Looks like this slipped through the cracks, can you merge this please @apoelstra