search

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
94 stars 49 forks source link

Add Fe32::ZERO const #185

Closed optout21 closed 3 months ago

optout21 commented 3 months ago

Add Fe32::ZERO const, which is the same as Fe32::Q, but with more intuitive name. Also replace Fe32::Q to Fe32::ZERO in a few relevant places.

apoelstra commented 3 months ago

concept ACK, though several of the changes from Q to ZERO I think make the code less clear.

optout21 commented 3 months ago

Reverted some of the renames as requested.

tcharding commented 3 months ago

Thanks for your contribution but NACK from me.

How is this better than using Fe32::Q. Also it begs the question why not have numerics for all 24 characters, and that would be horrible IMO.

clarkmoody commented 3 months ago

I also don't see the need for this, unless I'm missing something.

optout21 commented 3 months ago

Retracting