Add Default trait to Fe32

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding

MIT License

92 stars 48 forks source link

Closed optout21 closed 1 month ago

optout21 commented 1 month ago

LDK uses u5 from earlier version, and during the upgrade to Fe32 the Default ~~and Ord~~ traits were missed (PR).

Implementation would be trivial here, it just has to be derived. PR created to add them (#184).

apoelstra commented 1 month ago

I wouldn't mind adding Default which returns the zero element but Ord definitely does not make sense for a GF32 element.

optout21 commented 1 month ago

Updated description, as Ord trait was dropped.

tcharding commented 1 month ago

Closed by #184