search

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
93 stars 49 forks source link

Add optional dependency on ordering crate #190

Closed tcharding closed 1 month ago

tcharding commented 1 month ago

Add an optional dependency on the ordering crate and implement ArbitraryOrd for Fe32 if the feature is enabled.

tcharding commented 1 month ago

Requested by https://github.com/lightningdevkit/rust-lightning/issues/3195

tcharding commented 1 month ago

Something is wrong with the check api script, @apoelstra now that we removed it in rust-bitcoin what is your thoughts, are we removing it everywhere?

apoelstra commented 1 month ago

Yeah, let's remove it everywhere. These constant breakages I think are unacceptable given the way we were trying to use it. I also never got it to work with my local CI so we never really integrated it that well.

apoelstra commented 1 month ago

utACK a8ceeb65e91ce06915d556e2a14713884d65675b but the check-API commit should be changed to just remove the script.

tcharding commented 1 month ago

the check-API commit should be changed to just remove the script.

I don't understand this comment, I've rebased on #192 so that CI passes. If #192 is not right lets discuss it over there.

tcharding commented 1 month ago

Rebase only, no code changes.

apoelstra commented 1 month ago

FWIW I'm increasingly skeptical of this. It's not clear that anybody needs it and it increases our feature test matrix.

tcharding commented 1 month ago

I'll close since you are looking into the rust-lightning upgrade to use bech32 v0.11.0 and that is what this was for.