search

rust-bitcoin / rust-bech32

Bech32 format encoding and decoding
MIT License
94 stars 49 forks source link

A few cleanup commits #200

Closed apoelstra closed 1 month ago

apoelstra commented 1 month ago

This extracts 3 (hopefully) simple and non-controversial commits from my error-correction branch.

The first is just a clippy fix.

The second cleans up and simplifies the fuzztests (it does not bring over the new fuzztesting scripts from rust-bitcoin, use the bitcoin-maintainer-tools repo, introduce libfuzzer, etc.; it just does some basic cleanups to make things more useful).

And the third adds a few new bounds to the Field trait, specifically Neg<Output = Self> and Sum. (This is a breaking change.)

tcharding commented 1 month ago

Everything else looks good, I even checked fuzz/generate-files.sh for possibly the first time ever, to find it doesn't exist :)

apoelstra commented 1 month ago

@clarkmoody to get the fuzzer working locally you may need to install a different version of honggfuzz and/or run cargo update -p honggfuzz in the fuzz/ directory. My guess is that you are seeing version mismatch errors?