search

rust-bitcoin / rust-bitcoin-maintainer-tools

Scripts, test vectors, and other things used by or across multiple repositories in the rust-bitcoin ecosystem.
Creative Commons Zero v1.0 Universal
5 stars 3 forks source link

Grep for TODO #1

Open tcharding opened 5 months ago

tcharding commented 5 months ago

Consider adding a tool that greps for TODO (excluding changelog) as part of pre-release checks, at least for rust-bitcoin we should have no todo's in the codebase. I personally use them for questions and todos during dev that should not be merged but they slip through into master occasionally and should definitely not be released.

Note in point: 

cd path/to/rust-bitcoin
git checkout 85157078
git grep TODO
bitcoin/CHANGELOG.md:1:  # 0.32.0 - TODO: Add date when we do final release
bitcoin/src/consensus/mod.rs:151:            Other(_) => None, // TODO: Is this correct?
apoelstra commented 5 months ago

Also FIXME.