rust-bitcoin / rust-bitcoin

Rust Bitcoin library
Creative Commons Zero v1.0 Universal
2.1k stars 676 forks source link

CI: Make all crates in repo part of the workspace #3199

Open tcharding opened 2 months ago

tcharding commented 2 months ago

We have various crates (mostly test crates) that are excluded from the workspace, this means that there are deps not in the lock file and we cannot test this with nix setups.

Will likely require some care and possible patching of run_task.sh

tcharding commented 2 months ago

Should be easy to do if #3206 merges, and probably worth waiting until #3201 is done.

Kixunil commented 2 months ago

Also if different versions of dependencies get selected we're wasting CI time compiling them again. So concept ACK.

tcharding commented 6 days ago

Damn, looks like with all the CI changes I made we stopped testing with the embedded crates. I had a quick go at this issue but build issues, needs more time/effort.