Open tcharding opened 1 week ago
Yeah, we could change these ones. But I don't think in general we can do this -- e.g. I would expect the PSBT module to have multiple kinds of parse errors. In rust-minscript we definitely have this situation.
I also don't really think this matters ... if you are explicitly naming errors in your code then you need to be reading through docs anyway because they're named inconsistently throughout the entire ecosystem. But if you want to make this change, I'm cool with it.
No worries, thanks.
The
PsbtParseError
andParseAmountError
are inconsistent names. We have many other parsing errors and they are typically calledParseError
then users can use one level of path to qualify if they wish e.g.,psbt::ParseError
would be more consistent.