Release tracking PR - `v0.20.2-0.6.0`

rust-bitcoin / rust-bitcoinconsensus

Bitcoin's libbitcoinconsenus.a with Rust binding. Built from Bitcoin sources with cargo.

Apache License 2.0

46 stars 34 forks source link

Release tracking PR - `v0.20.2-0.6.0` #67

Closed tcharding closed 10 months ago

tcharding commented 11 months ago

In preparation for release bump the version and add a changelog entry.

apoelstra commented 11 months ago

This looks good and I think we could merge it as-is. But I think the ffi module should only contain C bindings, because that's idiomatically what users expect to find in a module called ffi. And these bindings should be exposed to the public.

tcharding commented 11 months ago

No worries.

EDIT: Deleted all the stuff I wrote as unnecessary for you to read after spending some more time playing with the PR.

tcharding commented 11 months ago

Force pushed the following:

Remove the support for the old pre-segwit verify function, it adds no value
Put only the C definitions into the ffi module
Further improved the docs

apoelstra commented 11 months ago

Could you move the version-bump commit to its own PR? It's easier for me to run my testing script.

apoelstra commented 11 months ago

but utACK 59459734bc968aa68a29cedc7174b68c43aba428

tcharding commented 11 months ago

Can do, no sweat!

tcharding commented 11 months ago

Can you merge and release please @apoelstra? Then I'll rebase #70, but that one will need a bit of thought to review because it involves changes to how we vendor the Core code.

apoelstra commented 10 months ago

Tagged and published.

tcharding commented 10 months ago

Legend!