search

rust-bitcoin / rust-bitcoinconsensus

Bitcoin's libbitcoinconsenus.a with Rust binding. Built from Bitcoin sources with cargo.
Apache License 2.0
46 stars 34 forks source link

Vendor Bitcoin Core v23.2 #85

Closed tcharding closed 9 months ago

tcharding commented 9 months ago

Run the vendoring script:

./contrib/vendor-bitcoin-core.sh v23.2

apoelstra commented 9 months ago

Lol, a different variant of the same bug.

I wonder if there's a newer version of the s390x image we could be using? Or a different big-endian box?

I seem to remember Github discontinuing s390x many years ago.. I'm surprised this is still running for us.

tcharding commented 9 months ago

Or a different big-endian box?

Yeah I had a bit of a scout around and didn't see one - I can look harder though.

apoelstra commented 9 months ago

For now I think we should just mark this CI job as optional :/. Let's get caught up with Core and then revisit this rather than having this open loop where we're struggling to deal with old code on old CI boxes and unable to move forward.

tcharding commented 9 months ago

Let's go!

tcharding commented 9 months ago

Gentle bump, can you take a look at this one please @apoelstra.

tcharding commented 9 months ago

Is this queued up for merge today @apoelstra ?