search

rust-bitcoin / rust-bitcoinconsensus

Bitcoin's libbitcoinconsenus.a with Rust binding. Built from Bitcoin sources with cargo.
Apache License 2.0
46 stars 34 forks source link

Vendor Bitcoin Core v24.2 #87

Closed tcharding closed 9 months ago

tcharding commented 9 months ago

Run the vendoring script:

./contrib/vendor-bitcoin-core.sh v24.2

Also, patch the build.rs file to add:

`.include("depend/bitcoin/src/secp256k1/include")`
tcharding commented 9 months ago

Not sure what to make of the build failures, cargo build works for me locally. Its failing when building secp, that led me to read the build.rs in secp and that is where the additional include came from. Any ideas @apoelstra? One thing that stands out is SECP256K1_API vs SECP256K1_BUILD (secp, bitcoinconsensus respectively).

EDIT: Silly me, its cargo test that is failing not cargo build

tcharding commented 9 months ago

Oh yeah, fixed it!

tcharding commented 9 months ago

I've got the release branch on my machine at home, I'll be back there in an hour to rebase it and push it up.

tcharding commented 9 months ago

Let me know please if you didn't want that merged for some reason.

tcharding commented 9 months ago

90 is ready to go.