search

rust-bitcoin / rust-bitcoind-json-rpc

Support for Bitcoin Core's JSON-RPC API
Creative Commons Zero v1.0 Universal
7 stars 4 forks source link

WIP: Add support for Bitcoin Core v28 #22

Open tnull opened 2 weeks ago

tnull commented 2 weeks ago

Based on #21.

Currently still work in progress (as v28.0rc1 has just been released, so no final binaries are available etc).

tnull commented 2 weeks ago

Thanks for working on this man. Can you pull the formatting changes out please, I was surprised to see changes to the json/src/v17 files.

Ah, now dropped them, didn't realize they slipped in as I didn't expect it either.

~Also, did you get the contents of rpc-ap.txt from running bitcoin-cli help against a Core v28 instance or did you copy'paste for another existing file?~ (EDIT: Oh submitpackage only exists in v28 so you must have used bitcoin-cli :)

Jup, run bitcoin-cli (took me a while to get where rpc-api.txts are coming from though :)

I merged #22 so you can rebase when you feel like it. Cheers

Cool, rebased for now, will resume work ~end of this week.

tcharding commented 2 weeks ago

(took me a while to get where rpc-api.txts are coming from though :)

Ha! So we need a "How to add support for a new version" doc. I'd love a script to check that all the rpc-ap.txt files actually come from bitcoin-cli help > rpc-api.txt for the correct version of Core and are not just copied from another file. Yesterday I was looking at the wrong buffer in my editor and thought I'd made a mistake so went back and checked manually. It would be nice to check that the mod.rs rustdoc is using the correct rpc-api.txt content as well, as it is we just have to hope I didn't get mixed up :)