search

rust-bitcoin / rust-miniscript

Support for Miniscript and Output Descriptors for rust-bitcoin
Creative Commons Zero v1.0 Universal
353 stars 139 forks source link

New release with rust-bitcoin 0.29 #452

Closed josediegorobles closed 1 year ago

josediegorobles commented 2 years ago

Hi, rust-bitcoin 0.29 is released yet, when is planned a new release of rust-miniscript with this version?

tcharding commented 2 years ago

No plans around here, its chaos mode :) I'm guessing soon as someone does the patch to upgrade the dependency. I'll try get to it today unless someone beats me to it.

tcharding commented 2 years ago

FYI the following crates have to upgrade before we can upgrade rust-miniscript

And latter requires the former to be released first.

josediegorobles commented 2 years ago

FYI the following crates have to upgrade before we can upgrade rust-miniscript

And latter requires the former to be released first.

Ok, first is done yet, is turn now of bitcoind (this issue: https://github.com/RCasatta/bitcoind/issues/82)

josediegorobles commented 2 years ago

Hi, now all the others are done, isn't it? What's the state of this issue?

josediegorobles commented 2 years ago

It's this PR: https://github.com/rust-bitcoin/rust-miniscript/pull/450

tcharding commented 2 years ago

That's the bitcoin upgrade, I don't know what else is to be done but there will be a release PR as well, that hasn't been done yet. You can do the release PR if you are keen, means writing release notes and bumping the version. Here are some examples

josediegorobles commented 2 years ago

Ok I can see it

josediegorobles commented 2 years ago

Hi @tcharding i made a PR: https://github.com/tcharding/rust-miniscript/pull/1 I put 7.1.0 version and the bump version on the CHANGELOG. ¿It's correct the version? ¿What other things must be in the CHANGELOG?

sanket1729 commented 2 years ago

Sorry for the delay in my response. @josediegorobles, your work looks great. In particular, for release PRs, I think it is best if the changelog PRs are made by maintainers. I made a draft PR for release #462

tcharding commented 2 years ago

I think it is best if the changelog PRs are made by maintainers.

Oh sorry, that was my fault then - I thought you might be busy and going through all the previous PRs is kinda tedious. I'll keep this in mind in future.

josediegorobles commented 2 years ago

The new release is with this draft PR: https://github.com/rust-bitcoin/rust-miniscript/pull/462

sanket1729 commented 2 years ago

Oh sorry, that was my fault then - I thought you might be busy and going through all the previous PRs is kinda tedious. I'll keep this in mind in future.

No worries. Sorry for the effort you and Jose put in :(. It's not a hard rule that maintainers must create a changelog, but mostly they have a good idea of which changes are important to highlight.

josediegorobles commented 2 years ago

Oh sorry, that was my fault then - I thought you might be busy and going through all the previous PRs is kinda tedious. I'll keep this in mind in future.

No worries. Sorry for the effort you and Jose put in :(. It's not a hard rule that maintainers must create a changelog, but mostly they have a good idea of which changes are important to highlight.

It's very reasonable to do it like that. No worries, and thank you all for your effort