rust-bitcoin / rust-miniscript

Support for Miniscript and Output Descriptors for rust-bitcoin
Creative Commons Zero v1.0 Universal
354 stars 139 forks source link

`checksum` module needs some love #610

Open tcharding opened 1 year ago

tcharding commented 1 year ago

After working on https://github.com/rust-bitcoin/rust-miniscript/pull/608 I noticed a few things:

Related:

apoelstra commented 1 year ago

Yeah, I agree with all these things. Confirmed that elements-miniscript is not using the checksum::Formatter type (it has its own).