rust-bitcoin / rust-miniscript

Support for Miniscript and Output Descriptors for rust-bitcoin
Creative Commons Zero v1.0 Universal
343 stars 135 forks source link

`Miniscript.substitute_raw_pkh()` is not recursive #728

Closed pythcoiner closed 1 week ago

pythcoiner commented 2 weeks ago

I hit a case here (the last assert fail) where the RawPkH seems not substituted.

It looks to me it's due to the fact the method is not recursive and the returned Miniscript is created from the last element of translated.

apoelstra commented 2 weeks ago

Fixed by #725