search

rust-bitcoin / rust-secp256k1

Rust language bindings for Bitcoin secp256k1 library.
Creative Commons Zero v1.0 Universal
336 stars 252 forks source link

We should also probably make `AlignedType` contain `MaybeUninit` or something like that, as the C code might write padding bytes to it. #707

Open apoelstra opened 2 weeks ago

apoelstra commented 2 weeks ago 
          We should also probably make `AlignedType` contain `MaybeUninit` or something like that, as the C code might write padding bytes to it.

I think it wasn't stable (enough) back when I implemented this logic

_Originally posted by @elichai in https://github.com/rust-bitcoin/rust-secp256k1/pull/635#discussion_r1667327931_

Kixunil commented 2 weeks ago

Indeed, MaybeUninit was stabilized quite late relative to both rust-bitcoin birth and my involvement in Rust.

tcharding commented 1 week ago

This weeks candidate for worst issue title ever :)

apoelstra commented 1 week ago

Yeah, sorry, normally I shorten the result of "reference in new issue" but I got lazy.