rust-bitcoin / rust-secp256k1

Rust language bindings for Bitcoin secp256k1 library.
Creative Commons Zero v1.0 Universal
351 stars 270 forks source link

Don't use `std`'s siphash to produce secret key fingerprints #725

Closed Kixunil closed 3 months ago

Kixunil commented 3 months ago

TL;DR: printing siphash of private keys is questionable cryptographically at best and people might accidentally rely on it despite it being unstable. Just replace it with a message saying to turn on hashes in secp256k1 if they want to see a fingerprint.

_Originally posted by @apoelstra in https://github.com/rust-bitcoin/rust-secp256k1/pull/722#discussion_r1730047892_