search

rust-bitcoin / rust-secp256k1

Rust language bindings for Bitcoin secp256k1 library.
Creative Commons Zero v1.0 Universal
350 stars 270 forks source link

Stop indexing hash types #731

Closed tcharding closed 2 months ago

tcharding commented 2 months ago

In preparation for removing SliceIndex from hash type impls (in bitcoin_hashes) lets stop indexing hash types here.

Internal change only.

jlest01 commented 2 months ago

ACK f0100e1c559ced3e60d91f449f4354be86a38a39

apoelstra commented 2 months ago

Idle thoughts:

I wonder if engine.input should be doing the .as_ref for us.

Also in rust-bitcoin we should make sure that all these hashes also implement AsRef<PushBytes>.