rust-bitcoin / rust-secp256k1

Rust language bindings for Bitcoin secp256k1 library.
Creative Commons Zero v1.0 Universal
350 stars 270 forks source link

Tidy up ellswift before the next major version release #754

Open shinghim opened 1 month ago

shinghim commented 1 month ago

In #752, Party was introduced to replace ElligatorSwiftParty. As part of the changes, shared_secret and shared_secret_with_hasher were updated to take Into<Party> to preserve backwards compatibility. These functions should probably just be taking Party instead of Into<Party> after ElligatorSwiftParty is removed in the next major version release.

apoelstra commented 1 month ago

We won't remove ElligatorSwiftParty in the next release. I'd give it at least two releases, maybe more.

But will keep this issue open to track it.