search

rust-bitcoin / rust-secp256k1

Rust language bindings for Bitcoin secp256k1 library.
Creative Commons Zero v1.0 Universal
350 stars 270 forks source link

Update the `secp256k1-sys` codebase to version v0.6. #764

Closed jlest01 closed 14 hours ago

jlest01 commented 1 week ago

This PR updates the secp256k1-sys codebase to version v0.6. I'm not sure if there are more steps involved, but these commits work fine in https://github.com/rust-bitcoin/rust-secp256k1/pull/716.

apoelstra commented 1 week ago

Thanks for doing this! Before running the vendor script, can you update the version in secp256k1-sys/Cargo.toml from 0.10.0 to 0.11.0? We need to update the version in order to make this releaseable, and because our vendoring code embeds the full version into all the symbols, and changing the name of these symbols is a breaking change, we don't have the ability to do minor bumps.

Could you also add an initial commit to this PR which edits secp256k1-sys/vendor-libsecp.sh to remove the patch version from DEFAULT_VERSION_CODE? I think adding | cut -d_ -f1-2 to the current command that computes it will do this.

I don't know why I didn't think to do this years ago..

jlest01 commented 1 week ago

@apoelstra thanks. I added two new initial commits.

apoelstra commented 1 week ago

Can you also update the Cargo-recent.lock and Cargo-minimal.lock files in the repo?

apoelstra commented 1 week ago

That should get CI passing -- then I can test the last commit and ACK it -- and then I'll ask you to squash everything, even though your change are logically separate and nicely separated. Because unfortunately none of the changes work without the others.

jlest01 commented 1 week ago

@apoelstra done. Thanks

jlest01 commented 1 week ago

I had squashed everything, but then I realized you asked to do it after the review. Cargo-recent.lock and Cargo-minimal.lock were changed in https://github.com/rust-bitcoin/rust-secp256k1/pull/764/commits/d88e6c27096b97a543e397e2649325bcf0bf04cb

apoelstra commented 6 days ago

utACK 0cdc758a56360bf58a851fe91085a327ec97685a

Thanks for iterating!!

If you squash everything I can do a tested ACK and merge it. (I already tested the tip so it will pass after squashing.)

apoelstra commented 6 days ago

Err, utack 32a533c130c855dfb7e7d4a6df910e530db8b4e2 I mean. Copied the wrong commit.

jlest01 commented 6 days ago

Thanks for reviewing. All commits squashed.