rust-bpf / rust-bcc

user-friendly rust bindings for the bpf compiler collection
MIT License
475 stars 54 forks source link

Feature: PerfEvent support. #106

Closed Skrinikov closed 4 years ago

Skrinikov commented 4 years ago
brayniac commented 4 years ago

Overall, looks good. I'd like to have an example that uses some software event that we can run in CI. Maybe cpu migrations or context switches would make a good smoke test.

For the function signature, I was thinking of ways we can start moving to a builder pattern in this library. Does not need to be addressed in this PR

brayniac commented 4 years ago

There are a couple other lints that you might want to address: https://github.com/rust-bpf/rust-bcc/pull/106/checks?check_run_id=920461866#step:4:40

Skrinikov commented 4 years ago

There are a couple other lints that you might want to address: https://github.com/rust-bpf/rust-bcc/pull/106/checks?check_run_id=920461866#step:4:40

Changed everything besides the fn signature max argument count for now.

not sure why format fails right now.