Closed Skrinikov closed 4 years ago
Overall, looks good. I'd like to have an example that uses some software event that we can run in CI. Maybe cpu migrations or context switches would make a good smoke test.
For the function signature, I was thinking of ways we can start moving to a builder pattern in this library. Does not need to be addressed in this PR
There are a couple other lints that you might want to address: https://github.com/rust-bpf/rust-bcc/pull/106/checks?check_run_id=920461866#step:4:40
There are a couple other lints that you might want to address: https://github.com/rust-bpf/rust-bcc/pull/106/checks?check_run_id=920461866#step:4:40
Changed everything besides the fn signature max argument count for now.
not sure why format fails right now.
attach_perf_event
bcc::core
PerfType
,PerfHardwareConfig
andPerfSoftwareConfig
are added correctly.cpu
is provided we usecpuonline::get
per call toattach_perf_event
(Some way to cache result)