Closed acj closed 4 years ago
Thanks for the PR. I'll have a chance to review it fully tomorrow. I think we'll be okay with breaking changes for this. I'll provide feedback in a review as soon as I have the time to look.
Feedback in-line. Only concern is around the error types where noted. Otherwise, this looks good to me. Thanks for doing this!
@brayniac Yes, good call on the error type. Fixed.
@javierhonduco Tests added. Good to see you over here :)
Thanks, both!