rust-bpf / rust-bcc

user-friendly rust bindings for the bpf compiler collection
MIT License
475 stars 54 forks source link

Improve error handling and reporting #138

Closed acj closed 4 years ago

acj commented 4 years ago
brayniac commented 4 years ago

Thanks for the PR. I'll have a chance to review it fully tomorrow. I think we'll be okay with breaking changes for this. I'll provide feedback in a review as soon as I have the time to look.

brayniac commented 4 years ago

Feedback in-line. Only concern is around the error types where noted. Otherwise, this looks good to me. Thanks for doing this!

acj commented 4 years ago

@brayniac Yes, good call on the error type. Fixed.

@javierhonduco Tests added. Good to see you over here :)

Thanks, both!