search

rust-bpf / rust-bcc

user-friendly rust bindings for the bpf compiler collection
MIT License
475 stars 54 forks source link

deprecate `init_perf_map()` #142

Closed brayniac closed 4 years ago

brayniac commented 4 years ago

Summary: I propose we deprecate init_perf_map() now that we have a PerfMapBuilder that gives us more flexibility over PerfMap configuration.

Justification: Marking the old function as deprecated will guide others to the new builder pattern for configuration without breaking things by providing a compiler warning. After some time, we can then remove the function outright.

Open Questions:

  1. How many releases should we leave it marked deprecated? Since we don't have a very steady release cadence, should we say 3 releases or 3 months, whichever is longer? I am open to suggestions for other durations.