Closed tobz closed 3 years ago
Thanks for working on this. Overall it looks pretty good.
There's a few other things that clippy is pointing out in this PR. Would be good to address the ones in the new code (src/usdt/mod.rs) - I think I commented on the only new one in core, there's some existing code causing some clippy warnings which can be ignored for the sake of this PR.
Very interested in this! Happy to take a look once it's ready for review! :)
Went through and did a bunch of cleanup and various bits, namely....
usdt
feature flag, added only by the versions that support the C API functions we required.CString
, I've cleaned up all instances where a CString
was being made, and added a contextual error message properly describing the error.usdt
module into core
so it could follow the file-per-major-API-changes approach.BPFBuilder
.I realize that the CString
stuff might be too noisy when trying to properly review the core aspect of this PR -- USDT support -- so I'm happy to revert those changes if need be.
Thanks @tobz - this is looking pretty solid now. I'll do one more pass of review once CI is green. Appreciate the contribution.
This PR adds USDT support, based on a transliteration of the Python implementation in
iovisor/bcc
.There's a lot of "icing" here as well: cleaning up styling, formatting, condensing code, etc.
Closes #167