Closed iximiuz closed 3 years ago
Thanks for the PR - this script is definitely geared to CI not necessarily end-user builds. Overall, I don't think there's a problem with making some of these changes.
See my comments in-line for some areas where I would like clarification on the intent of the change.
Closing in favor of #176 because I could not find a way to make changes to the PR created via GitHub UI.
I was trying to build this crate (including the static version of it) using
build/ci.sh
script and it didn't work out well for me because of the missing dependencies. Hence, a MR with a fix.