rust-build / rust-build.action

Automate publishing Rust build artifacts for GitHub releases through GitHub Actions
327 stars 51 forks source link

rust 1.74+ needs a newer macos SDK #88

Open mleduque opened 4 months ago

mleduque commented 4 months ago

It seems from 1.74 the minimum SDK version for macos is v10.12.

https://github.com/rust-lang/rust/pull/104385/ https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html

The current version of rust-build uses 10.10 (AFAIK)

lcmgh commented 4 months ago

Is that related to errors such as

 = note: ld: warning: object file (/tmp/rustcZt9O7X/symbols.o) was built for newer macOS version (10.12) than being linked (10.8)

?

mleduque commented 4 months ago

I think it is. In my case, I had those warnings but I also had a build failure because I had getrandom as transitive dep and https://github.com/rust-random/getrandom/blob/master/CHANGELOG.md#0212---2024-01-09 states

Raise minimum supported Apple OS versions to macOS 10.12 and iOS 10 https://github.com/rust-random/getrandom/pull/388

Odonno commented 4 months ago

I can confirm that it works with Rust 1.74 but it won't with a later version. Hope we will not be locked on this version for a long period of time.

jorgecarleitao commented 4 months ago

Unfortunately we do not have the tarballs for 10.12 in https://s3.dockerproject.org/ yet (which we use in https://github.com/rust-build/rust-build.action/blob/6febf1b0ed6499a46610b58ef9d810398e75f3c2/Dockerfile#L17

@Douile , do you know how these tarballs are created and uploaded to s3.dockerproject.org?

Douile commented 4 months ago

I believe it was found in a blog post (unlikely to get updated). New ones could possibly be sourced from https://github.com/joseluisq/macosx-sdks?tab=readme-ov-file

vianneybacoup commented 1 week ago

Any news on this ?

Douile commented 1 week ago

The long term fix for this is building using cross or github actions macos runner. Which is a complete rewrite of the action. I haven't had time to do this yet.