search

rust-cli / book

Documentation on how to use the Rust Programming Language to develop commandline applications
https://rust-cli.github.io/book/index.html
MIT License
816 stars 108 forks source link

Add `grss` implementation to errors chapter #233

Closed stomar closed 10 months ago

stomar commented 10 months ago

At the end of the chapter, provide a running code example that applies the nicer error reporting to the grrs tool.

stomar commented 10 months ago

I think the chapters following 1.3 should continue to improve the central grrs example step by step. This PR is a step in this direction.

See also #222.

stomar commented 10 months ago

I do not know how PRs are usually merged in this repository (squash, rebase, etc.); in this case I would prefer both commits were kept separately, i. e. no "squash and merge". IMO the second commit does not improve the text, as explained above; I also do not see any value in using an (empty) phrase merely for "consistency" with only 2 other uses.

Thanks.